Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2#27500 - Replace deprecated constructs from Payment P… #27596

Closed
wants to merge 4 commits into from
Closed

magento/magento2#27500 - Replace deprecated constructs from Payment P… #27596

wants to merge 4 commits into from

Conversation

cristiano-pacheco
Copy link
Contributor

@cristiano-pacheco cristiano-pacheco commented Apr 4, 2020

…HPUnit.

This PR is about the issue #27500 on item app/code/Magento/Payment

Description (*)

Changes were made to the payment module to be compatible with PHPunit in version 8.

Related Pull Requests

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 4, 2020

Hi @cristiano-pacheco. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@cristiano-pacheco
Copy link
Contributor Author

Hi @lbajsarowicz could you review this PR? please.

I made the changes for the tests of the Magento_Payment module, and tests of other modules are broken and therefore this PR did not pass.

How can I solve this?

@lbajsarowicz
Copy link
Contributor

Please take a look at Static Tests.
There you have information about line length exceeded and lack of annotations.

I will take care about CustomerBalance module.
That is actually strange, that something there depends on your Unit Tests.

@slavvka
Copy link
Member

slavvka commented Apr 15, 2020

@engcom-Foxtrot could you please taske a look at the failing Unit tests

@slavvka slavvka changed the base branch from 2.4-develop to phpunit8 April 16, 2020 14:49
Copy link
Member

@slavvka slavvka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@engcom-Foxtrot could you please taske a look at the failing Unit tests

@slavvka
Copy link
Member

slavvka commented Apr 23, 2020

@magento run all tests

@slavvka
Copy link
Member

slavvka commented Apr 23, 2020

@cristiano-pacheco Could you please resolve the conflicts

@slavvka
Copy link
Member

slavvka commented May 8, 2020

@cristiano-pacheco I am closing it since it was implemented in another PR. Thank you for your efforts!

@slavvka slavvka closed this May 8, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 8, 2020

Hi @cristiano-pacheco, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants