Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Removed redundant ActionGroup #27677

Merged
merged 1 commit into from
Apr 16, 2020
Merged

[MFTF] Removed redundant ActionGroup #27677

merged 1 commit into from
Apr 16, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Apr 9, 2020

Description (*)

This PR removes redundant ActionGroup
app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminOpenCategoriesPageActionGroup.xml
because we have similar app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminOpenCategoryPageActionGroup.xml

@m2-assistant
Copy link

m2-assistant bot commented Apr 9, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Apr 9, 2020
@rogyar rogyar self-requested a review April 9, 2020 13:50
@rogyar rogyar self-assigned this Apr 9, 2020
@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Apr 10, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7297 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Apr 14, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Echo engcom-Echo self-assigned this Apr 14, 2020
@engcom-Echo
Copy link
Contributor

@magento run Functional Tests B2B

@VladimirZaets VladimirZaets added this to the 2.4.0 milestone Apr 15, 2020
magento-engcom-team pushed a commit that referenced this pull request Apr 16, 2020
@slavvka
ENGCOM-7297: [MFTF] Removed redundant ActionGroup #27677
1427495
@magento-engcom-team magento-engcom-team merged commit c20d044 into magento:2.4-develop Apr 16, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 16, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Catalog Component: Cms Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Usik2203 @magento-engcom-team @engcom-Alfa @engcom-Echo @rogyar @VladimirZaets