-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed a duplicate variable in Magento\QuoteGraphQl\Model\Resolver\Cart and in \Magento\QuoteGraphQl\Model\Resolver\SetBillingAddressOnCart #27685
Conversation
Hi @bgorski. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@bgorski you missed a spot |
I did indeed, thanks! |
…Cart and in \Magento\QuoteGraphQl\Model\Resolver\SetBillingAddressOnCart
baec3ee
to
cc5f1bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Hi @rogyar, thank you for the review. |
QA not required |
…el\Resolver\Cart and in \Magento\QuoteGraphQl\Model\Resolver\SetBillingAddressOnCart #27685
Hi @bgorski, thank you for your contribution! |
Description (*)
Simply removed a duplicate variable. Nothing more to it.
$storeId = $storeId = (int)$context->getExtensionAttributes()->getStore()->getId();
became
$storeId = (int)$context->getExtensionAttributes()->getStore()->getId();
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
None required
Questions or comments
Contribution checklist (*)