Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed a duplicate variable in Magento\QuoteGraphQl\Model\Resolver\Cart and in \Magento\QuoteGraphQl\Model\Resolver\SetBillingAddressOnCart #27685

Conversation

bgorski
Copy link
Contributor

@bgorski bgorski commented Apr 10, 2020

Description (*)

Simply removed a duplicate variable. Nothing more to it.
$storeId = $storeId = (int)$context->getExtensionAttributes()->getStore()->getId();
became
$storeId = (int)$context->getExtensionAttributes()->getStore()->getId();

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

None required

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 10, 2020

Hi @bgorski. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@shawnabramson
Copy link

@bgorski you missed a spot

@bgorski
Copy link
Contributor Author

bgorski commented Apr 10, 2020

@bgorski you missed a spot

I did indeed, thanks!

…Cart and in \Magento\QuoteGraphQl\Model\Resolver\SetBillingAddressOnCart
@bgorski bgorski force-pushed the quote_graphql_resolver_duplicate_variable branch from baec3ee to cc5f1bc Compare April 10, 2020 03:35
@bgorski bgorski changed the title Removed a duplicate variable in Magento\QuoteGraphQl\Model\Resolver\Cart Removed a duplicate variable in Magento\QuoteGraphQl\Model\Resolver\Cart and in \Magento\QuoteGraphQl\Model\Resolver\SetBillingAddressOnCart Apr 10, 2020
@rogyar rogyar self-assigned this Apr 10, 2020
@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Apr 10, 2020
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7298 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

QA not required

@ghost ghost added the Progress: accept label Apr 15, 2020
@VladimirZaets VladimirZaets added this to the 2.4.0 milestone Apr 15, 2020
magento-engcom-team pushed a commit that referenced this pull request Apr 16, 2020
…el\Resolver\Cart and in \Magento\QuoteGraphQl\Model\Resolver\SetBillingAddressOnCart #27685
@magento-engcom-team magento-engcom-team merged commit b3f3f7b into magento:2.4-develop Apr 16, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 16, 2020

Hi @bgorski, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@bgorski bgorski deleted the quote_graphql_resolver_duplicate_variable branch May 3, 2020 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: QuoteGraphQl Partner: MRM Commerce partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants