Fixes incorrectly nested html in the product items list template.

[hostep]

Description (*)

MC-30989 introduced an incorrectly nested html structure in both Magento 2.3.5 and 2.4-develop

See #27920 for more details.

Fixed Issues (if relevant)

1. [2.3.5] Incorrect html structure after MC-30989 #27920: [2.3.5] Incorrect html structure after MC-30989

Manual testing scenarios (*)

1. Setup a clean Magento 2.3.5 or 2.4-develop (I've used commit 1e28f35)
2. Create a couple of simple products in the backend of Magento which are saleable
3. Open the first product you created and link the other products as crosssells to it
4. Reindex & flush caches
5. In the frontend, put that first product in your cart and go the the cart page
6. Look at the layout of the crosssells, it looks correct:

7. Simulate that the products are not saleable by changing the method Magento\Catalog\Model\Product::isSaleable to always return false
8. Refresh the cart page, see that the layout of the crosssell products is completely broken

9. After applying this fix the layout will not look broken again

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @hostep. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[rogyar]

Good catch!

[rogyar]

The failing tests are not related to the current change

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-7464 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Before: ✖️ layout of the crosssells is broken

After: ✔️ Now it looks correct

[magento-engcom-team]

Hi @ptylek, thank you for the review.
ENGCOM-7464 has been created to process this Pull Request

[m2-assistant]

Hi @hostep, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[hostep]

Thanks!

@slavvka: can we try to get this fix included in Magento 2.3.6 as well? Since the bug was introduced in 2.3.5.

[slavvka]

@hostep I raised this question to our POs

[slavvka]

Yes, they are going try to backport it there.