-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product should be assigned to option while option is assigned to product. #28301
Product should be assigned to option while option is assigned to product. #28301
Conversation
Hi @p-bystritsky. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. |
@magento run all tests |
@magento give me test instance |
Hi @lenaorobei. Thank you for your request. I'm working on Magento instance for you |
Hi @lenaorobei, here is your new Magento instance. |
a83f872
to
6047e8e
Compare
@magento run all tests |
48e239e
to
aed2eea
Compare
@magento run all tests |
@magento run Functional Tests B2B |
Closing in favor of #22917 revert. |
Hi @p-bystritsky, thank you for your contribution! |
Description (*)
Product is assigned to option while using Product::addOption method
magento2/app/code/Magento/Catalog/Model/Product.php
Lines 1977 to 1984 in 2d09485
Meanwhile Product::addOption method has no such assignment
magento2/app/code/Magento/Catalog/Model/Product.php
Lines 2032 to 2036 in 2d09485
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)