Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product should be assigned to option while option is assigned to product. #28301

Closed

Conversation

p-bystritsky
Copy link
Contributor

@p-bystritsky p-bystritsky commented May 20, 2020

Description (*)

Product is assigned to option while using Product::addOption method

public function addOption(Product\Option $option)
{
$options = (array)$this->getData('options');
$options[] = $option;
$option->setProduct($this);
$this->setData('options', $options);
return $this;
}

Meanwhile Product::addOption method has no such assignment
public function setOptions(array $options = null)
{
$this->setData('options', $options);
return $this;
}

Related Pull Requests

Fixed Issues (if relevant)

  1. None

Manual testing scenarios (*)

  1. None

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 20, 2020

Hi @p-bystritsky. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@rogyar
Copy link
Contributor

rogyar commented May 20, 2020

@magento run all tests

@lenaorobei
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, here is your new Magento instance.
Admin access: https://pr-28301.instances.magento-community.engineering/admin_f478
Login: 8ece0f81 Password: 7ea740f95290
Instance will be terminated in up to 3 hours.

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@p-bystritsky
Copy link
Contributor Author

@magento run all tests

@p-bystritsky
Copy link
Contributor Author

@magento run Functional Tests B2B

@lenaorobei
Copy link
Contributor

Closing in favor of #22917 revert.

@lenaorobei lenaorobei closed this Jun 1, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 1, 2020

Hi @p-bystritsky, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants