Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed code redundancy for module frontend layouts. #30644

Open
wants to merge 12 commits into
base: 2.4-develop
Choose a base branch
from
Open

Removed code redundancy for module frontend layouts. #30644

wants to merge 12 commits into from

Conversation

pratiksangani
Copy link
Contributor

@pratiksangani pratiksangani commented Oct 24, 2020 •
edited by m2-assistant bot
Loading

Description (*)

Removed code redundancy to theme layouts for Magento_Msrp, Magento_LoginAsCustomerAssistance, Magento_Newsletter & Magento_Sitemap modules frontend layouts.

Related Pull Requests

N/A

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Removed code redundancy for module frontend layouts. #30673: Removed code redundancy for module frontend layouts.

@pratiksangani
Removed code redundancy to theme layouts for Magento_Msrp, Magento_Lo…
e200706 
…ginAsCustomerAssistance, Magento_Newsletter & Magento_Sitemap modules frontend layouts.
@m2-assistant
Copy link

m2-assistant bot commented Oct 24, 2020

Hi @pratiksangani. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sidolov sidolov added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Oct 27, 2020
@sidolov
Copy link
Contributor

sidolov commented Oct 27, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Oct 27, 2020
Open
4 tasks
@pratiksangani
Copy link
Contributor Author

@magento run all tests

@pratiksangani
Copy link
Contributor Author

@sidolov Will you please proceed this PR?

@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jan 15, 2021
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ihor-sviziev ihor-sviziev self-assigned this Jan 15, 2021
@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Semantic Version Checker

ihor-sviziev
ihor-sviziev approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Approved.

Failing tests looks not related to changes form this PR.

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8657 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@pratiksangani thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@ihor-sviziev ihor-sviziev mentioned this pull request Mar 30, 2021
Closed
16 tasks
@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-November
Copy link
Contributor

@magento run Semantic Version Checker

@engcom-November
Copy link
Contributor

@magento run all tests

@engcom-November engcom-November self-assigned this Jun 20, 2024
@engcom-November
Copy link
Contributor

@magento run all tests

@engcom-November
Copy link
Contributor

As this is a code quality PR, manual testing is not applicable.

But since the builds are failed, moved it to Extended Testing.

@engcom-November
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, WebAPI Tests

@engcom-November
Copy link
Contributor

@magento run Integration Tests

@engcom-November
Copy link
Contributor

engcom-November commented Jun 21, 2024 •
edited
Loading

The repeating failures for Functional Tests B2B, CE and EE are flaky and known issues.

Functional Tests B2B
Run 1:
image

Run 2:
image

Known issues:
ACQE-6648 - StorefrontUpdateCustomerAddressBelgiumTest
ACQE-6695 - TierPricingWhenPriceScopeIsWebsiteWorkingProperlyWithMultipleCurrenciesConfiguredTest
ACQE-6321 - StoreFrontAddOutOfStockProductToShoppingCartTest

Functional Tests CE
Run 1:
image

Run 2:
image

Known issues:
ACQE-5825 - OrderDataGridDisplaysPurchaseDateTest
ACQE-6695 - TierPricingWhenPriceScopeIsWebsiteWorkingProperlyWithMultipleCurrenciesConfiguredTest

Functional Tests EE
Run 1:
image

Run 2:
image

Known issues:
ACQE-6523 - AdminReorderWithCatalogPriceRuleDiscountTest
ACQE-6695 - TierPricingWhenPriceScopeIsWebsiteWorkingProperlyWithMultipleCurrenciesConfiguredTest
ACQE-6331 - StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest

@engcom-November
Copy link
Contributor

The repeating WebAPI failure is flaky and known issue.

WebAPI Tests
Run 1:
image

Run 2:
image

Known issue:
ACP2E-3082 - testSendNegotiableQuoteCannotResend

Hence moving it to Merge in Progress.

@engcom-Charlie
Copy link
Contributor

@magento run Integration Tests

@engcom-Charlie
Copy link
Contributor

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@mrtuvn mrtuvn mrtuvn approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@mrtuvn mrtuvn

@engcom-Charlie engcom-Charlie

@engcom-Foxtrot engcom-Foxtrot

@engcom-November engcom-November

Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: LoginAsCustomerAssistance Component: Msrp Component: Newsletter Component: Sitemap Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
Status: Merge in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Removed code redundancy for module frontend layouts.