Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed usage of CliIndexerReindexActionGroup action group for Catalog module #31228

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Removed usage of CliIndexerReindexActionGroup action group for Catalog module #31228

merged 1 commit into from
Dec 21, 2020

Conversation

sergiy-v
Copy link
Contributor

@sergiy-v sergiy-v commented Dec 9, 2020 •
edited by m2-assistant bot
Loading

Description

Remove usage or changed value of CliIndexerReindexActionGroup action group from tests to improve execution time for the Catalog module.

Resolved issues:

  1. resolves [Issue] Removed usage of CliIndexerReindexActionGroup action group for Catalog module #31233: Removed usage of CliIndexerReindexActionGroup action group for Catalog module

@m2-assistant
Copy link

m2-assistant bot commented Dec 9, 2020

Hi @sergiy-v. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Catalog Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Dec 9, 2020
@sergiy-v
Copy link
Contributor Author

sergiy-v commented Dec 9, 2020

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B

@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Dec 9, 2020
@sidolov
Copy link
Contributor

sidolov commented Dec 9, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Dec 9, 2020
Closed
@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests B2B

@sergiy-v sergiy-v changed the title Removed usage of CliIndexerReindexActionGroup action group for Catalog module [WIP] Removed usage of CliIndexerReindexActionGroup action group for Catalog module Dec 10, 2020
@rogyar rogyar self-assigned this Dec 11, 2020
@rogyar
Copy link
Contributor

rogyar commented Dec 11, 2020

@magento run Functional Tests B2B

1 similar comment
@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests B2B

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE,Functional Tests B2B

@sergiy-v sergiy-v changed the title [WIP] Removed usage of CliIndexerReindexActionGroup action group for Catalog module Removed usage of CliIndexerReindexActionGroup action group for Catalog module Dec 14, 2020
@sergiy-v
Copy link
Contributor Author

Hello @rogyar.
Looks like previous fails for 'Functional Tests B2B' are not related to the changes, please check PR.

@rogyar rogyar added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: category of expertise labels Dec 16, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8546 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Dec 16, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Foxtrot engcom-Foxtrot self-assigned this Dec 17, 2020
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

magento-engcom-team pushed a commit that referenced this pull request Dec 21, 2020
@sidolov
ENGCOM-8546: Removed usage of CliIndexerReindexActionGroup action gro…
f6464ea 
…up for Catalog module #31228
@magento-engcom-team magento-engcom-team merged commit 5206cee into magento:2.4-develop Dec 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented Dec 21, 2020

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: category of expertise Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Removed usage of CliIndexerReindexActionGroup action group for Catalog module
6 participants
@sergiy-v @sidolov @rogyar @magento-engcom-team @engcom-Alfa @engcom-Foxtrot