Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MFTF] Refactoring AdminMassOrdersUpdateCancelPendingOrderTest #31512

Conversation

AnnaAPak
Copy link
Contributor

@AnnaAPak AnnaAPak commented Jan 4, 2021

Description (*)

The test is refactored to improve execution time

Related Pull Requests

#31509

Manual testing scenarios (*)

  1. Create an order
  2. Go to the Orders Grid
  3. Try to cancel the order via mass update
  4. Verify the result

Resolved issues:

  1. resolves [Issue] [MFTF] Refactoring AdminMassOrdersUpdateCancelPendingOrderTest #31514: [MFTF] Refactoring AdminMassOrdersUpdateCancelPendingOrderTest

@m2-assistant
Copy link

m2-assistant bot commented Jan 4, 2021

Hi @AnnaAPak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Sales Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 4, 2021
@AnnaAPak
Copy link
Contributor Author

AnnaAPak commented Jan 4, 2021

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jan 4, 2021
@sidolov
Copy link
Contributor

sidolov commented Jan 4, 2021

@magento create issue

@rogyar
Copy link
Contributor

rogyar commented Jan 5, 2021

Hi @AnnaAPak. Great job! Just small advice for the next time. Please, provide in the description short info on how exactly your changes reduce the execution time. It will speed up the PR review and delivery as the result.

For this particular case, it will be something like the following.

The changes introduced in the current PR invoke entities creation via API rather than entities creation via admin UI.

Thank you!

@rogyar rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jan 5, 2021
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8602 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

Note: QA not applicable

@engcom-Delta
Copy link
Contributor

Note: Functional Tests B2B, EE, CE are failed

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@gabrieldagama
Copy link
Contributor

@magento run all tests

@magento-engcom-team magento-engcom-team merged commit 44abb0d into magento:2.4-develop Feb 5, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 5, 2021

Hi @AnnaAPak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Sales Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Type: Test Coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] Refactoring AdminMassOrdersUpdateCancelPendingOrderTest
7 participants