Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated tedivm/jshrink dependency to PHP 8 compatible version #31800

Conversation

vlmed
Copy link
Contributor

@vlmed vlmed commented Jan 21, 2021

Description (*)

Update tedivm/jshrink dependency version from "~1.3.0" to "~1.4.0"

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/457

Fixed Issues (if relevant)

  1. Fixes Update tedivm/jshrink dependency to PHP 8 compatible version #31778

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 21, 2021

Hi @vlmed. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me php8-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 21, 2021
@vlmed
Copy link
Contributor Author

vlmed commented Jan 21, 2021

@magento run all tests

@vlmed vlmed force-pushed the update_tedivm_shrink_dependency_to_PHP8 branch from 0e6ca5f to 5f52967 Compare January 22, 2021 08:26
@vlmed
Copy link
Contributor Author

vlmed commented Jan 22, 2021

@magento run all tests

Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vlmed thanks for the pull request! Can you please also update EE composer.json and lock files and link the EE pull request using the related PR section. That should fix static tests

@vlmed
Copy link
Contributor Author

vlmed commented Jan 22, 2021

@magento run all tests

@sivaschenko
Copy link
Member

@vlmed I have updated ce and ee branches and linked EE pull request in the description of this PR

@magento run all tests

@coderimus coderimus self-requested a review January 28, 2021 13:14
Copy link
Contributor

@coderimus coderimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @vlmed
Please, fix conflicts for the composer.lock and one of the lib modules composer.json. Looks like this is a result of the latest PHP8 dev branch merge.

@vlmed
Copy link
Contributor Author

vlmed commented Jan 29, 2021

Hello @coderimus, @sivaschenko. Thanks for review. Conflicts have already been resolved.

@vlmed
Copy link
Contributor Author

vlmed commented Jan 29, 2021

@magento run all tests

@sivaschenko
Copy link
Member

@magento run all tests

@sivaschenko
Copy link
Member

@magento run WebAPI Tests,Functional Tests CE

@sivaschenko sivaschenko merged commit 91670d2 into magento:php8-develop Feb 1, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 1, 2021

Hi @vlmed, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: ready for testing Project: PHP8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants