-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[32279][GraphQL] Fixed issue with tier price #32353
[32279][GraphQL] Fixed issue with tier price #32353
Conversation
Hi @Usik2203. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Usik2203, could you please review the comments below?
Thank you.
@@ -152,7 +155,7 @@ private function formatAndFilterTierPrices( | |||
array $tierPrices, | |||
string $currencyCode | |||
): array { | |||
|
|||
$this->resetFormatAndFilterTierPrices(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not simply cleaning the formatAndFilterTierPrices
? Any concerns about that?
$this->resetFormatAndFilterTierPrices(); | |
$this->formatAndFilterTierPrices = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @eduard13
Unfortunately this approach isn't working in this case
We are losing some data
We will get tier price only for first item in this case
Example:
But actually banana-1
product has tier price
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But, I think you do the same in resetFormatAndFilterTierPrices
below, cleaning the formatAndFilterTierPrices
. Am I wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @eduard13
Yes you are right. It was my mistake 🤦
Fixed this one
Thanks!
/** | ||
* @magentoApiDataFixture Magento/Catalog/_files/three_simple_products_with_tier_price.php | ||
*/ | ||
public function testGetCorrectDisplaingTierPriceForProducts() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most probably we'll have to improve the test coverage, by having at least 1 product without tierPrices, in order to make sure it doesn't return anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**DONE **
Added one product without tier price.
045dd0b
to
457b0ea
Compare
@magento give me test instance |
…omer/PriceTiersTest.php Co-authored-by: Eduard Chitoraga <[email protected]>
@magento run all tests |
@magento run Functional Tests EE |
Hi @eduard13, thank you for the review. |
✔️ QA passed ❌ Before ✔️ After: |
Hi @Usik2203, thank you for your contribution! |
Description (*)
This PR fixes issue #32279
(Confirmed issue case #32279 (comment))
Preconditions
Tier price was added for product with name
banana
andbanana-1
BEFORE:
AFTER:
Fixed Issues (if relevant)