Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup wizard on php8-develop branch #32512

Merged

Conversation

hws47a
Copy link
Contributor

@hws47a hws47a commented Mar 16, 2021

Description (*)

There is an issue in php8-develop branch with setup wizard not working after updating of laminas-servicemanager.
This PR fixes is

Manual testing scenarios (*)

Open setup wizard and wait for content to appear.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fix setup wizard on php8-develop branch #32551: Fix setup wizard on php8-develop branch

@m2-assistant
Copy link

m2-assistant bot commented Mar 16, 2021

Hi @hws47a. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me php8-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Partner: Monsoon partners-contribution Pull Request is created by Magento Partner labels Mar 16, 2021
@hws47a
Copy link
Contributor Author

hws47a commented Mar 16, 2021

@magento run all tests

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B, Unit Tests

@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Mar 17, 2021
@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B

@sivaschenko
Copy link
Member

@magento create issue

@magento-cicd2 magento-cicd2 merged commit da519f8 into magento:php8-develop Mar 18, 2021
@m2-assistant
Copy link

m2-assistant bot commented Mar 18, 2021

Hi @hws47a, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: category of expertise Partner: Monsoon partners-contribution Pull Request is created by Magento Partner Progress: ready for testing Project: PHP8 Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants