Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed CliCacheFlushActionGroup usage for Downloadable and other modules #32517

Conversation

sergiy-v
Copy link
Contributor

@sergiy-v sergiy-v commented Mar 17, 2021

Description

Removed CliCacheFlushActionGroup usage for Downloadable, Elasticsearch, Elasticsearch6, Fedex, Indexer, LayeredNavigation, LoginAsCustomer, Msrp, Multishipping modules.

Resolved issues:

  1. resolves [Issue] Removed CliCacheFlushActionGroup usage for Downloadable and other modules #32518: Removed CliCacheFlushActionGroup usage for Downloadable and other modules

…h, Elasticsearch6, Fedex, Indexer, LayeredNavigation, LoginAsCustomer, Msrp, Multishipping modules
@sergiy-v
Copy link
Contributor Author

@magento create issue

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests CE,Semantic Version Checker

@m2-assistant
Copy link

m2-assistant bot commented Mar 17, 2021

Hi @sergiy-v. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests CE

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE,Functional Tests B2B

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE

@sergiy-v
Copy link
Contributor Author

@magento run WebAPI Tests, Unit Tests, Static Tests, Sample Data Tests EE, Sample Data Tests CE, Sample Data Tests B2B, Magento Health Index, Integration Tests, Database Compare

@eduard13 eduard13 self-assigned this Mar 23, 2021
@eduard13 eduard13 added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Mar 23, 2021
@magento-engcom-team
Copy link
Contributor

Hi @eduard13, thank you for the review.
ENGCOM-8964 has been created to process this Pull Request

@gabrieldagama gabrieldagama added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 25, 2021
@engcom-Oscar engcom-Oscar added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Mar 26, 2021
@engcom-Foxtrot engcom-Foxtrot self-assigned this Mar 26, 2021
@magento-engcom-team magento-engcom-team merged commit 3f7514e into magento:2.4-develop Apr 11, 2021
@m2-assistant
Copy link

m2-assistant bot commented Apr 11, 2021

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Downloadable Component: Elasticsearch Component: Fedex Component: Indexer Component: LayeredNavigation Component: LoginAsCustomer Component: Msrp Component: Multishipping Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Type: Test Coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Removed CliCacheFlushActionGroup usage for Downloadable and other modules
6 participants