Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support newline in javascript translates #3892

Conversation

stevenvdp
Copy link
Contributor

Currently it's not possible to add translates in js-translation.json if you use a newline after the opening brackets of the translate helper function in your templates.

This pull requests adds support for the following cases:

$.mage.__(
    'This is a string'
);
$.mage.__(
    "This is a string"
);

$t(
    "This is a string"
);
$t(
    'This is a string'
);

…the one with the opening/closing brackets (mage_translation_widget)
…the one with the opening/closing brackets (mage_translation_static)
@daim2k5
Copy link
Contributor

daim2k5 commented Mar 30, 2016

Thank you for your contribution. Please accept the contributors license agreement so this PR can be further processed. This can be done by clicking the "Details" link next to the "license/cla" check below.

@stevenvdp
Copy link
Contributor Author

I added the email address used in the commit in my Github account, the CLA is now marked correctly

@okorshenko
Copy link
Contributor

Internal ticket: MAGETWO-52573

@okorshenko okorshenko added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label May 5, 2016
@okorshenko okorshenko self-assigned this May 5, 2016
@magento-team magento-team merged commit 4086dfb into magento:develop May 10, 2016
@okorshenko
Copy link
Contributor

@stevenvdp Thank you for contribution. Your Pull Request merged to develop branch.

magento-engcom-team pushed a commit that referenced this pull request Mar 13, 2019
[EngCom] Public Pull Requests - GraphQL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants