Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for code that is not following best practices in Magento development #48

Closed
wants to merge 2 commits into from
Closed

Patch for code that is not following best practices in Magento development #48

wants to merge 2 commits into from

Conversation

IvanChepurnyi
Copy link
Contributor

See attached commit, where using of collection for retrieving address by id is replaced by using of standard load method of the model.

Created as new pull request, since previous one was using master branch, instead of custom one.

@magento-team
Copy link
Contributor

@IvanChepurnyi
Thank you for the valuable contribution and mistakes-free implementation. Your contribution has been accepted, it will be available with the upcoming publications.

Automated tests for these particular changes appeared to be pretty simple, so we implemented them.
However, please make sure to supply all contributions with automated tests (unit or integration).

Closing the ticket

magento-team added a commit that referenced this pull request Aug 27, 2012
* Decoupled Tag module functionality from other modules
* Visual Design Editor:
  * Implemented tracking of user changes history and rendering the actions at VDE toolbar
  * Implemented compacting of user changes history. Compacting is done in order to save all the changes as a minimal layout update.
* Improvements:
  * Added Atlassian IDE Plugin configuration files to `.gitignore`
  * Relocated `add_to_cart`, `checkout` and `product_edit` performance scenarios from `samples` to the normal `testsuite` directory. These scenarios can be used for Magento performance testing.
  * Implemented verification of number of orders that were created during execution of `checkout` performance scenario
  * Removed usage of deprecated `PHPUnit_Extensions_OutputTestCase` class from unit tests
* Fixes:
  * Fixed MySQL DB adapter to always throw exception, if it was not able to connect to DB because of wrong configuration. So now the adapter's behavior is not dependent on `error_reporting` settings.
  * Added the missing closing tag to New Order email template
  * Fixed `Mage_ImportExport_Model_Import_Entity_CustomerComposite` integration test issues
  * Marked several integration tests in `Mage_Adminhtml_CustomerControllerTest` as incomplete, as the tested functionality was not MMDB-compliant
  * Fixed issue with unit tests failure, when there was a Zend Framework installed as PEAR package
  * Fixed `advanced_search` performance scenario to fail, if the searched product doesn't exist
  * Fixed issue with non-escaped latest message link in admin backend
* GitHub requests:
  * [#48](#48) -- fixed usage of a collection at the place, where just a single object was needed
magento-team pushed a commit that referenced this pull request Jan 23, 2015
[Firedrakes] Magento vendor name is used as a framework namespace
@stevieyu stevieyu mentioned this pull request Apr 3, 2015
@chrom chrom mentioned this pull request Oct 7, 2015
okorshenko pushed a commit that referenced this pull request Oct 29, 2015
magento-engcom-team pushed a commit that referenced this pull request May 31, 2018
- Fixed test in case when indexer mode is 'on schedule'
magento-engcom-team pushed a commit that referenced this pull request Aug 27, 2018
MAGETWO-66666: Adding a product to cart from category page with an ex…
@FabXav FabXav mentioned this pull request Oct 11, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants