Change Request for InvokerDefault::_callObserverMethod() #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…method_exists it should be is_callable
|
@SchumacherFM, thank you for your contribution! We created the ticket, the team will look at it according to the priorities. We will get back to you once we complete the analysis. |
magento-team
added a commit
that referenced
this pull request
Jun 6, 2014
* Framework improvements:
* Covered the following Magento application components with unit tests:
* `SalesRule/Model/Observer`
* `SalesRule/Helper/*`
* `SalesRule/Model/Plugin/*`
* `SalesRule/Model/System/Config*`
* `Sales/Model/Config.php`
* `Sales/Model/Download.php`
* `Sales/Model/Quote.php`
* Covered the following Magento lib form elements with unit tests:
* `lib/Magento/Framework/Flag.php`
* `lib/Magento/Framework/Escaper`
* `lib/Magento/Framework/Event`
* `lib/Magento/Framework/Logger`
* `lib/Magento/Framework/Util`
* `lib/Magento/Framework/Registry.php`
* `lib/Magento/Framework/Backup/Media`
* `lib/Magento/Framework/Backup/NoMedia`
* `lib/Magento/Framework/Archive`
* `lib/Magento/Framework/Translate.php`
* Created Service API for Magento_Catalog module:
* AttributeSet service
* AttributeSetGroup service
* ProductLinks service
* ProductType service
* Payments Improvements:
* Resolved a performance issue with Merchant Country selector under Payment Methods settings
* Removed the PayPal Payments Pro Payflow Edition payment solution
* Removed the Saved Credit Card payment method
* Added the following functional tests:
* Delete Admin User
* Delete Backend Customer
* Delete Product UrlRewrite
* Downloadable Product Creation
* Update Simple Product
* Update Tax Rule
* Update Tax Rate
* Suggest Searching Result
* Fixed bugs:
* Fixed an issue where the Create Order page title was not correct when scrolling down was performed
* Fixed the concurrent test running in MTF
* Fixed an issue where product custom options were merged incorrectly
* Fixed an issue where customer group discount was not applied for bundle products
* Fixed an issue where it was impossible to create a refund for the PayPal Exprecch Checkout Payflow Edition if captured from the PayPal admin
* Fixed an issue where adding customer review caused an error in system.log
* Fixed an issue where the Manage Stock option was automatically reset to No after changing the Stock Availability option
* Fixed an issue where the recurring profile attributes where displayed for a product when they were not included in the product attribute set.
* Fixed an issue where a fatal error appeared in some cases on attempt to add a product to cart when FPT was enabled
* Fixed an issue where back in stock product alert emails showed HTML markup
* Fixed an issue where the Refresh Statistics link on the Sales Report page redirected to the frontend after setting Add Store Code to Urls to Yes
* Fixed an issue where the selected bundle options price was included to the price displayed in the MAP popup
* Fixed an issue where the wrong allowed countries list was used in Checkout
* Fixed an issue where configurable products with out of stock associated simple products were displayed in layered navigation
* Fixed an issue where configurable products lost options after being duplicated using the Save and Duplicate button
* Fixed issues with simple product custom options where it was impossible to import them from a product page and they were not duplicated correctly using the Save and Duplicate button
* Fixed an issue where it was impossible to create a customer on the backend in a single store mode
* Fixed an issue where reviews created on the backend appeared with the Guest status
* Fixed an issue where it was impossible to add an image for a configurable product variation during editing
* Processed GitHub requests:
* [#539] (#539) The "{config.xml,*/config.xml}" pattern cannot be processed
* [#564] (#564) Catalog product images - Do not removing from file system
* [#256] (#256) Unused file app\code\core\Mage\Backend\view\adminhtml\store\switcher\enhanced.phtml
* [#561] (#561) Bugfix Magento\Framework\DB\Adapter\Pdo\Mysql::getForeignKeys()
* [#576] (#576) Change Request for InvokerDefault::_callObserverMethod()
|
@SchumacherFM, we have just released the new version dev81 containing the fix for this issue. Thank you again for reporting this issue! |
magento-team
pushed a commit
that referenced
this pull request
Sep 7, 2015
[Tango] S59 - Support Tool, Bug Fixes
mmansoor-magento
pushed a commit
that referenced
this pull request
Nov 8, 2016
Bugs - MAGETWO-59905 Order create page broken after refresh
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Dec 4, 2023
ACPT-1665:Fix searchConfig merge in SearchCriteriaBuilder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
method_exists()it should beis_callable()within an OO environment.It should be possible that you can use observer objects with the magic __call implementation and a "non-existing" method.
There is a nice blog post about those two functions: http://blog.jmfeurprier.com/2010/01/03/method_exists-vs-is_callable/
method_exists(): There are also 25 more occurrences in theappfolder and 23 inlib/Magento. Maybe you can consider changing them also tois_callable(), if not it would be at least nice if you accept that PR :-)Thanks!