Add Sort Order to Rules #598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sub Product discounts use this function separately from the main product. In some cases Sub Products would run a different rule to the main product.
|
@drdrak3, thank you for your contribution! We created the ticket and placed it to the backlog. We will get back to you once the team processes it. |
magento-team
added a commit
that referenced
this pull request
Jul 11, 2014
* Service layer updates:
* Created Category service and methods
* Renamed attribute option service
* Implemented an API method to remove for attribute options
* Created TaxClass service and methods
* Created APIs for Tax service
* Framework improvements:
* REST/SOAP calls uses default store if store code not provided
* Added a warning about using a not secure protocol for theidentity link URL
* Fixed exception masking and removed unnecessary exceptions from the Webapi framework
* WEEE features parity:
* Fixed an issue with Tax calculations when FPT is enabled
* Fixed an issue where FPT was not included in the subtotal number on invoice pages
* Fixed an issue where FPT was not included in the subtotal number on credit memo pages
* Free shipping calculated with FPT
* Fixed an issue where discounts where applied to FPT
* Fixed an issue with rounding is the Tax detailed info
* Fixed issues with bundle product pricing with tier and special prices
* Added an integrity test to verify that dictionary and code are synced
* i18n Improvements:
* Improved the wording of the i18n CLI Tools
* Removed the helpers which became unused after i18n Improvements
* Fixed bugs:
* Fixed an issue where configurable attributes were not chosen according to the hash tag
* Fixed an issue where the Compare Products functionality did not work correctly
* Fixed an issue where product attribute values were duplicated after import
* Fixed an issue were the scope of an attribute was not considered in catalog price rule conditions
* Fixed an issue where shipping address was not saved if it was added during checkout
* Fixed an issue where there was no POST request when saving a customer group
* Fixed an issue where an attribute template was not applied after changing it for the first time during product creation
* Fixed an issue where the Sale Report Grid with no results found contained an unnecessary empty Total section
* Fixed an issue where a notice was added to system.log when a product was added to cart
* Fixed integration test coverage failure
* Fixed an issue where a message about inequality of password and confirmation was displayed in the wrong place
* Fixed an issue with an XSS warning in 'Used for Sorting in Product Listing' property of Product Attribute
* Fixed an issue where an order was not displayed on frontend if its order status was deleted
* Fixed an issue where tier pricing was not displayed on a grouped product page
* Verified and fixed the content of errors returned from SOAP calls
* Fixed an issue where it was impossible to create a tax rule when using a complex Customer/Product tax class
* Fixed an issue where the Street Address line count setting was not applied.
* Fixed an issue where customers were not assigned to the correct VAT customer groups during admin order creation
* The unused translateArray method of AbstractHelper was removed
* Fixed an issue where localization did not work for strings containing a single quote (')
* Fixed issues with the translate and the logging transformation tools
* Fixed an issue where it was impossible to create a URL rewrite for a CMS Page with Temporary (302) or Permanent (301) redirect
* GitHub requests:
* [#598] Add Sort Order to Rules
* [#580] Set changed status on model to prevent status overwriting when model gets saved
* Unit Tests Coverage:
* Part of the Catalog module covered with the unit tests
* Added the following functional tests:
* Applying Several Catalog Price Rules
* Attribute Set Creation
* Category Deletion
* Customer Group Deletion
* Generating Sitemap
* Product Attribute Deletion
* Update Admin User
* Update Cms Page
* Update Customer Group
* Update Downloadable Product
* Update Product Attribute
* Update Sales Rule
* Update Sitemap
|
@drdrak3, the team processed your contribution and deployed it to GitHub in version dev86. Thank you for helping us make Magento better! We are closing this issue. |
magento-team
pushed a commit
that referenced
this pull request
Oct 21, 2015
[Merchant Beta][MX] Bugfixes for beta 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sub Product discounts use this function separately from the main product.
In some cases Sub Products would run a different rule to the main product.
To replicate:
When getting the product price discount, it correctly gets the 10% discount.
However, when getting the sub product price discount, it incorrectly gets the 50% discount.
This happens because there is no ordering on the Sub Product discounts, so it MySQL applies a default order by rule_id