Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve some tests and keep it working: #66

Closed
wants to merge 2 commits into from
Closed

improve some tests and keep it working: #66

wants to merge 2 commits into from

Conversation

Forestsoft-de
Copy link

Test/EnvironmentTest.php

  • getInstance will not throw an exception if all tests are running.
  • make set instance null possible and check for type magento_environtment.
  • implement skipped Varien_Date tests.
    is it correct that %s property will be ignored? the test failed yet.

Implementation of ImageMagickTest will not work under windows because touch is an unix command.
check for environtment and skip these tests.

you should think about using of vfsStream for file system tests.

Test/EnvironmentTest.php
getInstance will not throw an exception if all tests are running.
make set instance null possible and check for type magento_environtment.

implement skipped Varien_Date tests.
is it correct that %s property will be ignored? the test failed yet.

Implementation of ImageMagickTest will not work under windows because touch is an unix command.
check for environtment and skip these tests.

you should think about using of vfsStream for file system tests.
@magento-team
Copy link
Contributor

@Forestsoft-de
Sebastian, thank you for valuable contribution. Let's dissect it and see what was done in result:

  • dev/tests/unit/framework/Magento/Test/Environment.php and related tests. After careful inspection we decided to remove it at all. After this change the unit testing framework happens to not have any other classes, so we removed the framework as well. With this change the unit tests in Magento become implemented using "out of the box" features of PHPUnit.
  • dev/tests/unit/testsuite/Varien/DateTest.php
    • Didn't accept contribution for convertZendToStrfTime(), because this method was eliminated during refactoring of calendar to jQuery. The change is stuck in one of development branches though, but we'll incorporate it into master branch in near future.
    • Accepted testFormatDate() as is -- thank you
  • dev/tests/unit/testsuite/Varien/Image/Adapter/ImageMagickTest.php -- partially accepted your contribution and also refactored the test to not create any files in the first place.

magento-team added a commit that referenced this pull request Nov 12, 2012
* Framework changes
  * Added dependency injection of framework capability
    * Adopted Zend\Di component of Zend Framework 2 library
    * Implemented object manager in Magento application
    * Refactored multiple base classes to dependency injection principle (dependencies are declared in constructor)
  * Themes/View
    * Implemented storing themes registry in database, basic CRUD of themes, automatic registration of themes in database from file system out of the box
    * Renamed `Mage_Core_Model_Layout_Update` into `Mage_Core_Model_Layout_Merge`, the former becomes an entity domain model. Similar changes with `Mage_Core_Model_Resource_Layout` -> `Mage_Core_Model_Resource_Layout_Update`, `Mage_Core_Model_Layout_Data` -> `Mage_Core_Model_Layout_Update`
* Performance tests
  * Improved indexers running script `dev/shell/indexer.php` to return appropriate exit code upon success/failure
  * Implemented running the same performance scenario file with different parameters
  * Slightly refactored framework class `Magento_Performance_Testsuite_Optimizer` for better visibility of algorithm
* Visual design editor
  * Added ability to remove elements in editor UI
  * Revised history of changes VDE toolbar and algorithm of "compacting" operations (moving, removing elements) as a layout update XML
  * Added selection of themes to VDE launcher page
* Refactored JavaScript of some UI elements to jQuery:
  * "Simple" and "configurable" product view pages
  * "Create Account" page
  * "Shopping Cart" page
  * CAPTCHA
  * Newsletter subscription
* Tax management UX improvements
  * Split Basic and Advanced Settings for Tax Rule Management UI
  * Moved the Import/Export functionality to Tax Rate page
  * Moved Tax menu to System from Sales
* Implemented the editable multiselect JavaScript component
* Added mentioning sitemap in `robots.txt` after generation
* Removed creation of DB backup in integration testing framework
* Fixed logic of order of loading ACL resources in backend
* Fixed JavaScript error during installation when one of files in `pub/media` is not writable
* Fixed structure of legacy test fixtures that allowed ambiguous keys in declaration
* Fixed inability to restore admin password when CAPTCHA is enabled
* Various minor UX fixes (labels, buttons, redirects, etc...)
* GitHub requests:
  * [#59](#59) -- implemented handling of unexpected situations in admin/dashboard/tunnel action
  * [#66](#66)
    * refactored ImageMagick adapter unit test to avoid system operation
    * simplified unit testing framework -- removed unused classes, simplified handling logic of directory `dev/tests/unit/tmp` and removed it from VCS
  * [#73](#73), [#74](#74) -- fixes in docblock tags
  * [#75](#75), [#96](#96) -- fixed translation module contexts in a few places
  * [#80](#80) -- fixed some runtime errors in import/export module
  * [#81](#81) -- removed usage of "remove" directive in places where it is overridden by setting root template anyway
  * [#87](#87) -- changed paths of files to include from relative into absolute in `dev/shell/indexer.php` and `log.php`
  * [#88](#88) -- provided comments for values that can be configured in `app/etc/local.xml` file
  * [#90](#90) -- slightly optimized logic of implementation of loading configurable product attributes
magento-team pushed a commit that referenced this pull request Jan 30, 2015
@jkchan jkchan mentioned this pull request Oct 6, 2015
okorshenko pushed a commit that referenced this pull request Oct 29, 2015
magento-team pushed a commit that referenced this pull request Mar 23, 2016
JS-339: [SwatchRenderer.js] Preload images for all available options
@abi2 abi2 mentioned this pull request Sep 19, 2016
@ghost ghost mentioned this pull request Feb 2, 2017
@ghost ghost mentioned this pull request Oct 21, 2017
magento-engcom-team pushed a commit that referenced this pull request Aug 2, 2018
MQE-1068: Require Issue ID for Skipped Test
magento-engcom-team pushed a commit that referenced this pull request Apr 29, 2020
…er/issues/28

magento2-login-as-customer/issues/28: Admin order noted in Order Comments.
@FabXav FabXav mentioned this pull request Oct 11, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants