Quote values in IN() predicate to avoid cast issues #8714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Values in IN() predicate must be quoted as it may lead to cast issues otherwise.
Experienced: Two SKUs composed of numbers, one with prefix, one without.
When importing the first one, the query returns both because of MySQL casting:
SELECT sku FROM catalog_product_entity WHERE sku IN (123456789)returns123456789
123456789-old
while
SELECT sku FROM catalog_product_entity WHERE sku IN ("123456789")returns the correct response123456789