Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent overwriting grunt config #8910

Merged

Conversation

Igloczek
Copy link
Contributor

@Igloczek Igloczek commented Mar 16, 2017

Description

By default Magento stores sample configs as go to config. Any update will overwrite config files added by users.

I simply rename config file to be *.sample and add previous one to gitignore, same way as package.json and gruntfile.js.

Fixed Issues

It's a fix for #7196.

@Igloczek
Copy link
Contributor Author

@ishakhsuvarov

@ishakhsuvarov ishakhsuvarov self-assigned this Mar 16, 2017
@ishakhsuvarov ishakhsuvarov added this to the March 2017 milestone Mar 16, 2017
@omiroshnichenko
Copy link
Contributor

Hi, @Igloczek. Your issue already solved in Magento. What you need to do:

  1. Copy grunt-config.json.sample to grunt-config.json.
  2. Copy dev/tools/grunt/configs/themes.js to dev/tools/grunt/configs/local-themes.js
  3. Specify your themes config in dev/tools/grunt/configs/local-themes.js

But, I just find the issue that dev/tools/grunt/configs/local-themes.js and grunt-config.json absent in .gitignore file. Kindly ask you to add these files to .gitignore in current pull request. Thanks.

@Igloczek
Copy link
Contributor Author

Makes sense. I reverted my previous changes and push that one recommended by you.

@ishakhsuvarov
Copy link
Contributor

@Igloczek Thanks for the quick fix!

@okorshenko
Copy link
Contributor

@Igloczek thank you for your contribution

@Igloczek Igloczek deleted the prevent-overwriting-grunt-config branch March 17, 2017 07:14
magento-devops-reposync-svc pushed a commit that referenced this pull request Jun 5, 2024
…24-olga

[Support Tier-4 omoyseyenko] 04-29-2024 Regular delivery of bugfixes and improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants