Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty system message #922

Closed
wants to merge 3 commits into from
Closed

Conversation

snky1987
Copy link

@snky1987 snky1987 commented Jan 6, 2015

Fixed issue with empty system message popup when issue has been fixed in the other window and current window wasn't refreshed.

Default message to display hard coded in controller.

Created separate pull request as from now on every single fix will be pushed to separate branches (as it should be) also fixed Coding standards issues.

If any Travis CI issues will appear due to coding standards it will be about differences between Windows and Unix environment (line endings).

@otoolec
Copy link
Contributor

otoolec commented Feb 3, 2015

I've updated internal ticket MAGETWO-32969 from issue #919 to point to this pull request for processing.

@otoolec otoolec added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 3, 2015
@vrann vrann self-assigned this Feb 24, 2015
@anupdugar
Copy link
Contributor

@snky1987 Any updates based on suggestions provided in #919 ?

@snky1987
Copy link
Author

Hi @anupdugar I know i promissed to do it last week. I have really busy time. Tried to take a look on it today but my ebay project is too expensive to do side tasks. I will come back to it asap (probably this week). I promise :) Cheers.

@anupdugar
Copy link
Contributor

@snky1987 Did you get a chance to work on this? If not, maybe we can close this for now and you can create another when the fixes are ready.

@anupdugar
Copy link
Contributor

@snky1987 Closing this for now since we haven't heard back in a while.
Feel free to create a PR if you have the suggested improvements ready or any further questions. Thanks again for reporting this!

@anupdugar anupdugar closed this Mar 6, 2015
magento-team pushed a commit that referenced this pull request Mar 14, 2017
MAGETWO-65784: [FT] Incorrect navigation menu item names in Admin
fe-lix- pushed a commit to fe-lix-/magento2 that referenced this pull request Apr 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants