Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page meta title fix in case breadcrumb section is removed via XML #9324

Merged
merged 2 commits into from
Apr 22, 2017

Conversation

latenights
Copy link
Member

@latenights latenights commented Apr 20, 2017

Description

Page meta title is visible only if breadcrumbs block is defined (not removed) in XML. If you remove it, page meta title disappears from category view and product view page.

Fixed Issues (if relevant)

  1. SEO/HEAD - Meta title is null when breadcrumb section is removed via XML #4427:SEO/HEAD - Meta title is null when breadcrumb section is removed via XML

Manual testing scenarios

  1. Remove breadcrumbs block in XML <referenceBlock name="breadcrumbs" remove="true"/>
  2. Go to the category view or product view page
  3. Check Page title in browser tab

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Apr 20, 2017

CLA assistant check
All committers have signed the CLA.

@okorshenko okorshenko self-assigned this Apr 20, 2017
@okorshenko okorshenko added this to the April 2017 milestone Apr 20, 2017
@magento-team magento-team merged commit 231cfc7 into magento:2.1-develop Apr 22, 2017
@magento-team
Copy link
Contributor

@latenights thank you for your contribution to Magento 2 project

@maksek
Copy link
Contributor

maksek commented Aug 22, 2017

Hi @latenights, can you provide your email, so I can contact you regarding PR.

@latenights
Copy link
Member Author

Hi @maksek , you can contact me at nudavmeste(at)nudavmeste.sk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants