Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emogrifier update to latest version #9327

Closed

Conversation

Bartlomiejsz
Copy link
Contributor

@Bartlomiejsz Bartlomiejsz commented Apr 20, 2017

New version of #7110 made from develop branch.
Fixes #6946 and #4737

@okorshenko okorshenko self-assigned this Apr 20, 2017
@okorshenko okorshenko added this to the April 2017 milestone Apr 20, 2017
@ishakhsuvarov
Copy link
Contributor

Hi @Bartlomiejsz
Please check the unit tests fail.

@Bartlomiejsz
Copy link
Contributor Author

@ishakhsuvarov I'm not sure what is wrong here. Running phpunit -c dev\tests\static . locally ends without errors. Also I don't think my changes broke something here. Maybe you should try rerunning travis?

@ishakhsuvarov
Copy link
Contributor

@Bartlomiejsz I've restarted the Travis job, however I am pretty sure issue is going to persist.
You referred to the dev/tests/static however the job for unit tests was failed, try running a whole scope of unit tests.
Sadly, due to error, currently Travis would not show exact tests which were failed, I am working on a fix for this issue.

@Bartlomiejsz
Copy link
Contributor Author

@ishakhsuvarov I've tried to run a whole scope of tests, and it failed. But it returned me following error:
Fatal error: Class 'Magento\TestFramework\TestCase\WebapiAbstract' not found in ...\dev\tests\api-functional\testsuite\Magento\Analytics\Api\LinkProviderTest.php on line 20

But when I tried to run tests on develop branch, it also failed, returning exactly same error.

@ishakhsuvarov
Copy link
Contributor

@Bartlomiejsz Looks like the unit which fails is
Magento\Email\Test\Unit\Model\Template\FilterTest::testApplyInlineCss
Please check

@okorshenko okorshenko modified the milestones: April 2017, May 2017 May 9, 2017
@okorshenko
Copy link
Contributor

@Bartlomiejsz would you like to proceed with this PR or we can close it?

@Bartlomiejsz
Copy link
Contributor Author

@okorshenko yes, I would, but unfortunately right now I have some problems with my computer. So any help here would be appreciated

@okorshenko okorshenko modified the milestones: May 2017, June 2017 Jun 1, 2017
@okorshenko
Copy link
Contributor

@Bartlomiejsz thank you for your contribution. Please create new PR when ready. Closing this PR for now

@okorshenko okorshenko closed this Jun 5, 2017
@magento magento locked and limited conversation to collaborators Jun 5, 2017
@Bartlomiejsz Bartlomiejsz deleted the Emogrifier_Update_2 branch November 14, 2018 19:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants