Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving documentation for jMeter performance tests #964

Merged
merged 2 commits into from
Jan 21, 2015

Conversation

jonathanvaughn
Copy link
Contributor

While trying to play with the jMeter tests we discovered that the documentation was occasionally misleading / confusing, and also lacking some details.

  • Source download of jMeter lacks the .jar for jMeter itself and thus is insufficient to work
  • Once you install the additional libraries for graphing reports etc, you have to actually enable them for them to work
  • Performance Metrics Collection will keep the jMeter test from completing if you do not have the agents set up / configured the jMeter settings for your server environment, etc.
  • generate.php must be used to generate test data, at least in our experience, Sample Data did not work with jMeter test.
  • There are a number of additional configurable parameters that were undocumented, such as specifying the admin username / password / path.

@vpelipenko vpelipenko added the MX label Jan 15, 2015
@kokoc kokoc self-assigned this Jan 20, 2015
@kokoc kokoc added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jan 20, 2015
@kokoc
Copy link
Member

kokoc commented Jan 21, 2015

✅ CR: passed
✅ Builds: green
✅ Resolution: ready to merge
✅ Internal reference: MAGETWO-32881

kokoc added a commit that referenced this pull request Jan 21, 2015
Improving documentation for jMeter performance tests
@kokoc kokoc merged commit ae761e3 into magento:develop Jan 21, 2015
@kokoc kokoc added Progress: accept and removed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Jan 21, 2015
magento-team pushed a commit that referenced this pull request Jan 23, 2015
[Github] Improving documentation for jMeter performance tests #964
kokoc added a commit that referenced this pull request Jan 30, 2015
Improving documentation for jMeter performance tests
magento-team added a commit to abeeskau/magento2-community-edition that referenced this pull request Feb 9, 2015
* UI improvements:
    * Updated the design of Enable Cookies CMS page
    * Implemented UI improvements for Widgets
    * Fixed the "Help Us to Keep Magento Healthy Report All Bugs (ver. #)" link Magento Admin
    * Various UI improvements
* Various improvements:
    * Implemented Sales Quote as a standalone Magento module
    * Performed custom EAV entities code and DB tables cleanup
    * Eliminating remnants of the Core module:
        * Moved Application Emulation from the Magento_Core module to the Magento_Store module
        * Moved Validator Factory from the Magento_Core module to the Magento Framework
    * Added static integrity test for composer.json files
    * Added PHPMD and PHPCS annotations to the codebase
* Tests improvements:
    * Added MVP tag to the functional tests
    * Created acceptance functional test suite
    * Replaced end-to-end tests for url rewrite creation, CMS page creation, category creation, review creation, customer frontend creation, and tax rule creation with injectable tests
    * Automated test cases for downloadable products with taxes
* Fixed bugs:
    * Fixed an issue where the Discounts and Coupons RSS Feed had incorrect title
    * Fixed an issue where a wrong special price expiration date was displayed in RSS
    * Fixed an issue in the Import functionality where imported files disappeared after the Check Data operation
    * Fixed an issue where the Unsubscribe link in the Newsletter was broken
    * Fixed an issue where stock status changed incorrectly after import
    * Fixed an issue where selected filters and exclude did not work during Export
    * Fixed an issue where tax details order was different on order/invoice/refund create and view pages (
    * Fixed a typo in the getCalculationAlgorithm public function
    * Fixed an issue where the incorrect value of Subtotal Including Tax was displayed in invoices
    * Fixed an issue where tax details were not displayed on a new order
    * Improved pricing performance using caching
    * Fixed an issue where CsvImportHandler tests still referring to links from Tax module instead of TaxImportExport module
    * Fixed an issue where an exception was thrown instead of 404 if altering the url for a product with required configuration on the storefront
    * Fixed an issue where the title of successfully placed order page (was empty
    * Fixed an issue where certain fields were not disabled by default on the website scope in System configuration as expected
    * Fixed an issue where third party interfaces were not supported by single-tenant compiler
    * Eliminated the 'protocol' parameter from the ReadInterface and WriteInterface
* GitHub requests:
    * [#979](magento/magento2#979) -- Adding OSL license file name
    * [#978](magento/magento2#978) -- Added ignore rule for media assets in wysiwyg directory
    * [#877](magento/magento2#877) -- Made Topmenu HTML Editable
    * [#906](magento/magento2#906) -- Add tests for View\Layout\Reader\Block and slight refactoring
    * [#682](magento/magento2#682) -- \Magento\Framework\Pricing\PriceCurrencyInterface depends on Magento application code
    * [#581](magento/magento2#581) -- About ByPercent.php under different currencies
    * [#964](magento/magento2#964) -- Improving documentation for jMeter performance tests
    * [#871](magento/magento2#871) -- Replace Symfony2/Yaml in composer
    * [#990](magento/magento2#990) -- add @see annotation before class to make it recognizable by IDE
    * [#988](magento/magento2#988) -- Prevent Varnish from creating cache variations of static files
* Framework improvements:
    * Improved unit and integration tests coverage
magento-team pushed a commit that referenced this pull request Mar 25, 2017
magento-team pushed a commit that referenced this pull request Dec 12, 2017
…o\Framework\Data\Tree::getNodeById() #964

 - Merge Pull Request magento-engcom/magento2ce#964 from RomaKis/magento2:8507
 - Merged commits:
   1. bd6d35c
   2. 2ee2326
magento-team pushed a commit that referenced this pull request Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants