extra tests for current interception behavior #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public function beforeW(Intercepted $subject, $param1) | ||
| { | ||
| return ['<F:bV/>']; |
There was a problem hiding this comment.
Should this be "bW" instead of bV? Same for the aroundW().
|
Looks like this exposes a bug with the processing order. @bluk highlighted that the call to method z in the test should show F was processed last. $this->assertEquals('<F:aZ/>', $subject->Z('test'));. This is the simple case where we reverse order on the way out but that does not appear to be the case. @antonkril can you look and confirm this? I say simple since Z only has two after plugins so the lowest sort order should be called last on the way out. |
|
Thanks for these excellent test cases @fooman! I've opened up MAGETWO-32851 internally to resolve the inconsistency between the behavior and documentation. |
muasir
added
bug report
Issue: Ready for Work
otoolec
added a commit
that referenced
this pull request
Jan 30, 2015
…965 - Fixed license headers - Moved fields from GeneralTest to AbstractPlugin
otoolec
added a commit
that referenced
this pull request
Jan 30, 2015
…965 - Fix license header in FirstPlugin
otoolec
added a commit
that referenced
this pull request
Jan 30, 2015
…965 - Suppress warnings for test fixtures
vpelipenko
added a commit
that referenced
this pull request
Jan 30, 2015
[Github] extra tests for current interception behavior #965
magento-team
added a commit
to abeeskau/magento2-community-edition
that referenced
this pull request
Feb 7, 2015
* Various improvements:
* Implemented caching for WebAPI configuration
* Improved tests coverage of the CurrencySymbol module
* Table catalogsearch_fulltext is setting up with ENGINE=InnoDB
* Improved unit test coverage of the Catalog related functionality
* Optimized JS dependencies
* Refactored controller actions in the Sales module
* Refactored controller actions in the Customer module
* Removed the assertion for the exact number of attributes in API-functional tests for customer metadata.
* Refactored API code for the CheckoutAgreements module
* Refactored API code for the GiftMessage module
* Refactored API for the Checkout module
* Fixed bugs:
* Fixed an where issue were WebAPI generated the wrong WSDL
* Fixed an issue where Catalog, Checkout, Customer API ACLs did not support AJAX use case(s)
* Fixed an issue where SOAP tests failed after upgrading to ZF 1.12.9
* Fixed an issue where the 'There is no data for export' message was displayed permanently after invalid search
* Fixed an issue where there was no ability to set category position during creation it
* Fixed a CSS issue where certain images were absent on banners ()
* Fixed an issue where the 'Date Of Birth' value was i reset to current date on the customer form)
* Fixed an issue where the behavior of the "Terms and Conditions" validation on multiple address checkout was different from the one for the onepage checkout
* Fixed an issue where it was impossible to checkout with multiple addresses
* Fixed an issue where the 'This is a required field ' message was not displayed for "Terms and Conditions" if the latter was not selected
* GitHub Requests:
* [#963](magento/magento2#963) -- Default Accept header
* [#995](magento/magento2#995) -- Prevent a warning in activated developer mode when 'plugins' is no array
* [#866](magento/magento2#866) -- Configurable product attribute scope
* [#965](magento/magento2#965) -- extra tests for current interception behavior
* Service Contracts:
* The Downloadable module basic implementation
* Framework improvements:
* Refactored and covered with tests the classes with high CRAP value (>50)
* Moved Theme Management changes, Design changes, Design\Backend modules, and Observer components from the Core module to the Theme module
* Moved Debug Hints models from the Core module to the newly added Developer module
* Moved URL components, Factory, and EntityFactory from the Core module to the Magento Framework
* UI improvements:
* Compressed and resized images
* Added new base styles for the Admin re-design
* Added the WAI-ARIA attributes are to the Search Autocomplete on the storefront
* Added visual style for the 'skip to content' attribute on the storefront
* Fixed the style of persistent login messages on the storefront for all themes
* Fixed the style of scrolling for Categories with long names in the Admin
* Fixed the "css/print.css" file path on the storefront pages for all themes
* Tests improvements:
* Converted all fixtures/repositories for functional tests to .xml files
* Improved interaction between webdriver and the new Magento JS forms
* Increased unit and integration tests coverage
magento-team
added a commit
to abeeskau/magento2-community-edition
that referenced
this pull request
Feb 9, 2015
* Various improvements:
* Implemented caching for WebAPI configuration
* Improved tests coverage of the CurrencySymbol module
* Table catalogsearch_fulltext is setting up with ENGINE=InnoDB
* Improved unit test coverage of the Catalog related functionality
* Optimized JS dependencies
* Refactored controller actions in the Sales module
* Refactored controller actions in the Customer module
* Removed the assertion for the exact number of attributes in API-functional tests for customer metadata.
* Refactored API code for the CheckoutAgreements module
* Refactored API code for the GiftMessage module
* Refactored API for the Checkout module
* Fixed bugs:
* Fixed an where issue were WebAPI generated the wrong WSDL
* Fixed an issue where Catalog, Checkout, Customer API ACLs did not support AJAX use case(s)
* Fixed an issue where SOAP tests failed after upgrading to ZF 1.12.9
* Fixed an issue where the 'There is no data for export' message was displayed permanently after invalid search
* Fixed an issue where there was no ability to set category position during creation it
* Fixed a CSS issue where certain images were absent on banners ()
* Fixed an issue where the 'Date Of Birth' value was i reset to current date on the customer form)
* Fixed an issue where the behavior of the "Terms and Conditions" validation on multiple address checkout was different from the one for the onepage checkout
* Fixed an issue where it was impossible to checkout with multiple addresses
* Fixed an issue where the 'This is a required field ' message was not displayed for "Terms and Conditions" if the latter was not selected
* GitHub Requests:
* [#963](magento/magento2#963) -- Default Accept header
* [#995](magento/magento2#995) -- Prevent a warning in activated developer mode when 'plugins' is no array
* [#866](magento/magento2#866) -- Configurable product attribute scope
* [#965](magento/magento2#965) -- extra tests for current interception behavior
* Service Contracts:
* The Downloadable module basic implementation
* Framework improvements:
* Refactored and covered with tests the classes with high CRAP value (>50)
* Moved Theme Management changes, Design changes, Design\Backend modules, and Observer components from the Core module to the Theme module
* Moved Debug Hints models from the Core module to the newly added Developer module
* Moved URL components, Factory, and EntityFactory from the Core module to the Magento Framework
* UI improvements:
* Compressed and resized images
* Added new base styles for the Admin re-design
* Added the WAI-ARIA attributes are to the Search Autocomplete on the storefront
* Added visual style for the 'skip to content' attribute on the storefront
* Fixed the style of persistent login messages on the storefront for all themes
* Fixed the style of scrolling for Categories with long names in the Admin
* Fixed the "css/print.css" file path on the storefront pages for all themes
* Tests improvements:
* Converted all fixtures/repositories for functional tests to .xml files
* Improved interaction between webdriver and the new Magento JS forms
* Increased unit and integration tests coverage
magento-team
pushed a commit
that referenced
this pull request
Mar 25, 2017
[EngCom] Public Pull Requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests further document the current behaviour when using multiple extensions intercept the same method. The example method implementation does not follow best practice approach, they do not use the Closure and break the execution chain.