Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mod_expires dynamic content #987

Merged

Conversation

PHOENIX-MEDIA
Copy link

HTML, TXT and CSV files are allowed to be cached in the browser and proxies for one year with the mod_expires default setting in .htaccess files. This shouldn't be allowed by default as it doesn't allow you to control and refresh HTML content. The change sets "Cache-Control: max-age=0" header for HTML and other plain text content.

@vpelipenko vpelipenko added the PS label Jan 21, 2015
@PHOENIX-MEDIA PHOENIX-MEDIA changed the title Fix mod deflate dynamic content Fix mod_expires dynamic content Jan 21, 2015
@kokoc kokoc self-assigned this Jan 27, 2015
@kokoc
Copy link
Member

kokoc commented Feb 4, 2015

Thank you for contribution.
Internal reference: MAGETWO-33614

@vpelipenko vpelipenko added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed TECH labels Feb 17, 2015
@vrann vrann assigned vrann and unassigned kokoc Feb 24, 2015
@vrann
Copy link
Contributor

vrann commented Feb 24, 2015

Hi @PHOENIX-MEDIA,
This improvement will work for apache-based installation of Magento. As a part of repository we also have sample files for nginx configuration (nginx.conf.sample), which should be updated in the same way.
Are you willing to do that change?

@PHOENIX-MEDIA
Copy link
Author

I would rather say no as we currently don't use Nginx with Magento.

@vrann
Copy link
Contributor

vrann commented Mar 11, 2015

Sure, we will take care of that. Thanks!

@magento-team magento-team merged commit 6efe85c into magento:develop Mar 23, 2015
@sshrewz
Copy link

sshrewz commented Mar 23, 2015

@PHOENIX-MEDIA, this is now available in 0.74.0-beta1. Thank you very much for your contribution and continued support to Magento 2!

fe-lix- pushed a commit to fe-lix-/magento2 that referenced this pull request Apr 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants