Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused App component breaking test watch mode #143

Merged
merged 1 commit into from
Jul 12, 2018

Commits on Jul 11, 2018

  1. chore: Remove unused App component breaking test watch mode

    - Updated Jest dep to `^23.4.0`, fixing jestjs/jest#6407 which caused our `test:dev` script to appear to hang when files were modified and Jest cache was absent. The original behavior froze at this message:
    
           Determining test suites to run...
    
      The new version of Jest properly prints the error message:
    
           Determining test suites to run...
    
           Configuration error:
    
           Could not locate module src/store/reducers/navigation mapped as:
           /Users/jzetlen/gits/pwa/pwa-studio/packages/venia-concept/src/store/reducers/navigation.
    
           Please check your configuration for these entries:
           {
             "moduleNameMapper": {
               "/^src\/(.+)/": "/Users/jzetlen/gits/pwa/pwa-studio/packages/venia-concept/src/$1"
             },
             "resolver": null
           }
    
    - Removed the `App` component, which is now unused due to the `MagentoResolver` calling `RootComponents` directly, and was the source of the mapping error above. Future errors of this kind will appear early and should be easier to diagnose and fix.
    zetlen committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    8c24d6e View commit details
    Browse the repository at this point in the history