Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php 8 compatibility in Zend_Xml_Security class #37

Conversation

karyna-t
Copy link

@karyna-t karyna-t commented Sep 10, 2021

This PR adds compatibility with PHP 8 for zendframework1 (Zend_Xml_Security)

Testing PRs to magento with custom branch
magento/magento2#33991
magento/partners-magento2ee#604

esler and others added 2 commits May 12, 2021 10:01
fixes "PHP Fatal error:  Uncaught ValueError: version_compare(): Argument magento#3 ($operator) must be a valid comparison operator" error message under PHP 8.0
@karyna-t karyna-t changed the title php 8 compatibility in Zend_Xml_Security class #36 php 8 compatibility in Zend_Xml_Security class Sep 10, 2021
@xmav
Copy link

xmav commented Sep 15, 2021

@magento import pr to magento-commerce/zf1

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit c8ab365 into magento:master Sep 15, 2021
@karyna-t karyna-t deleted the php8-compatibility/zf-compatibility-with-php8 branch September 30, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants