Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heroku yml file #58

Closed
wants to merge 1 commit into from
Closed

Add heroku yml file #58

wants to merge 1 commit into from

Conversation

Ilyeo
Copy link
Contributor

@Ilyeo Ilyeo commented Jun 26, 2024

Quick Info

I attempted to make a manual deployment using the Heroku CLI and noticed this error:

image

It seems we need this Heroku config file, which indicates how to build the app, specifies add-ons for the app’s needs, and also takes advantage of the review apps.

All of this seems to be very new, as the official docs have an April 2024 date (last updated April 25, 2024).

After adding this Heroku file and trying to deploy it again, It was successful. You can review it here on staging.

@magmaleads magmaleads temporarily deployed to today-i-lear-chore-add--qvdhwa June 26, 2024 02:33 Inactive
@Ilyeo Ilyeo requested review from softr8 and vicmaster June 26, 2024 02:43
@Ilyeo
Copy link
Contributor Author

Ilyeo commented Jun 28, 2024

The team decided not to merge this, opting to continue using buildpacks. Consequently, the Heroku app setting has changed from container to buildpack.

@Ilyeo Ilyeo closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants