Add KeyedList question type along with render, configuration, and tests. #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeyedList derives its behavior from List but allows the developer to define an explicit key press associated with each element that a user can use to directly select that entry vs. key Up/Down. KeyedList supports an `auto_confirm` argument that allows an entry to be selected just by the corresponding key. Also supports multiple key matches by jumping through selections on each key press.
|
@firephreek thank for your change. Do you mind rebasing it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New question type that derives from List but allows choice selection via alpha-numeric keypress. By default, keys are generated using the first letter or number of the provided label. Multiple keys can be cycled through by repeated key presses.
KeyedListsupports anauto_confirmkeyword argument (defaults to False) that allows an entry to be selected just by the its corresponding key. It's theme is derived fromListand unit tests are also taken directly from List along with new tests to confirm all selection behaviors and most variations.Open design decisions: Adding surround or leading characters to the key in label and possibly adding theming to call out the available key press. Otherwise, KeyedList should be able to serve as a drop in replacement for List without any change to the underlying functionality including instantiation.