This repository has been archived by the owner on Jun 25, 2021. It is now read-only.
Add documentation to Cache and fix a possible bug #2582
Merged
+30
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 14, 2021 14:12
`Cache::set` was not testing the removed item's expiry, meaning expired values could be returned.
This works around a compilation issue caused by rust-lang/rust#85574. A more permanent fix may come in future.
This has been unused since #2556.
|
Had to fix a couple of actions issues @dirvine, but it's green across the board now! |
dirvine
approved these changes
Jun 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e8ed35b docs(cache): Populate empty doc comments
a67164c refactor(cache): Avoid suppressing lints
b5dab42 fix(cache): Prevent exposing expired values from Cache::set
Cache::setwas not testing the removed item's expiry, meaning expiredvalues could be returned.
93de8c8 ci: Install cargo-udeps without --locked
This works around a compilation issue caused by
Backwards-incompatible lifetime change (regression) rust-lang/rust#85574. A more permanent fix may
come in future.
37fc9da chore: Remove unused dashmap dependency
This has been unused since fix(comm): ignore connection loss #2556.