Change to use stylelint for CSS/SCSS linting
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `sass-lint` package is not maintained anymore and hasn't been updated in a long time. Current de facto CSS/SCSS linter is now `stylelint`. The output is very similar to the `sass-lint` tool, so this simply updates the `ArcanistSassLintLinter` to rather work with the `stylelint` tool instead. The old `ArcanistScssLintLinter` has been removed.
asteinlein
approved these changes
Nov 3, 2020
| ($parts[1] === 'error' || $parts[1] === 'warning')) { | ||
| $severity = $parts[1] === 'error' ? | ||
| ($parts[1] === '✖' || $parts[1] === '⚠')) { | ||
| $severity = $parts[1] === '✖' ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sass-lintpackage is not maintained anymore and hasn't beenupdated in a long time. Current de facto CSS/SCSS linter is now
stylelint. The output is very similar to thesass-linttool, so thissimply updates the
ArcanistSassLintLinterto rather work with thestylelinttool instead. The oldArcanistScssLintLinterhas beenremoved.