Expose focus-trap configuration #295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an extension to #178 released with 0.2.1 and enables more fine grained control over the focus-trap, which might be necessary to work around issues with clickOutsideDeactivates vs allowOutsideClick described in [the projects README](https://github.com/focus-trap/focus-trap#createfocustrapelement-createoptions) It also documents that configuration option in the projects README.
pichfl
force-pushed
the
pichfl/focus-trap-configuration
branch
from
5d4b127
to
a1bdc87
Compare
|
the problem with this is that we are adding the focus-trap API to our own public API and any breaking change to the focus-trap API means that we also have to make a breaking API change. I would prefer to solve the use cases where focus-trap option changes are necessary by abstracting these option in our own API in some way instead of directly exposing the library. The fact that we're using focus-trap IMHO should be seen as an implementation detail. |
|
Works for me, I'll make a new PR exposing some of the options and documents these. |
|
Did this end up going anywhere? I'm in the process of migrating our app's modals implementation over to
|
kevinansfield
added a commit
to TryGhost/ember-promise-modals
that referenced
this pull request
Sep 13, 2021
refs mainmatter#435 refs mainmatter#295 https://github.com/focus-trap/focus-trap is used internally for keeping focus inside a modal and for clicks outside to close the modal. It's `clickOutsideDecactivates` config is exposed allowing for clicks on wormholed elements such as dropdowns inside a modal to not close the modal unexpectedly, however without the companion `allowOutsideClick` config those clicks are prevented from performing any interaction. - added `allowOutsideClick` to the options passed through from the `modals` service to the `focus-trap` initialisation
kevinansfield
added a commit
to TryGhost/ember-promise-modals
that referenced
this pull request
Sep 13, 2021
refs mainmatter#435 refs mainmatter#295 https://github.com/focus-trap/focus-trap is used internally for keeping focus inside a modal and for clicks outside to close the modal. It's `clickOutsideDecactivates` config is exposed allowing for clicks on wormholed elements such as dropdowns inside a modal to not close the modal unexpectedly, however without the companion `allowOutsideClick` config those clicks are prevented from performing any interaction. - added `allowOutsideClick` to the options passed through from the `modals` service to the `focus-trap` initialisation
kevinansfield
added a commit
to TryGhost/ember-promise-modals
that referenced
this pull request
Sep 16, 2021
refs mainmatter#435 refs mainmatter#295 https://github.com/focus-trap/focus-trap is used internally for keeping focus inside a modal and for handling modal closing on certain events. If the consuming app wants to manage deactivation/close-inducing events itself then it needs some way to pass `focus-trap` config through to turn off that functionality. - added `escapeDeactivates` to the options passed through from the `modals` service to the `focus-trap` initialisation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension to #178 released with 0.2.1 and enables more fine grained control over the focus-trap, which might be necessary to work around issues with clickOutsideDeactivates vs allowOutsideClick described in the projects README.