Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional onAnimationModalOutEnd hook #421

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Conversation

nickschot
Copy link
Member

@nickschot nickschot commented Jul 27, 2021

This hook is called when the modal finishes its closing animation. Can be used to for example clean up CSS variable overrides.

@nickschot nickschot requested a review from pichfl July 27, 2021 08:44
@nickschot nickschot added the enhancement New feature or request label Jul 27, 2021
@nickschot nickschot force-pushed the out-animation-hook branch 2 times, most recently from 060bc26 to 54f5177 Compare July 27, 2021 08:51
README.md Outdated Show resolved Hide resolved
@nickschot nickschot changed the title add optional onOutAnimationEnd hook add optional onAnimationModalOutEnd hook Jul 27, 2021
@nickschot nickschot requested a review from a team July 27, 2021 14:48
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉

@nickschot nickschot merged commit e2daed5 into master Jul 27, 2021
@nickschot nickschot deleted the out-animation-hook branch July 27, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants