Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show how to extend the session service in the README #2310

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mcfiredrill
Copy link
Contributor

@mcfiredrill mcfiredrill commented Jun 18, 2021

Continuing from my comment here, there isn't any info about this in the docs so yet.
#2285 (comment)

As far as I understand this is the preferred way to set a routeAfterAuthentication so this should definitely be in the docs, right?

Continuing from my comment here, there isn't any info about this in the docs so yet.
mainmatter#2285 (comment)
@mcfiredrill mcfiredrill changed the title WIP: show how to extend the session service in the README show how to extend the session service in the README Jun 18, 2021
README.md Outdated
* @var {Service}
*/
handleAuthentication() {
this.router.transitionTo('dashboard.boards');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would write super.handleAuthentication('dashboard.boards') instead. That way, the default logic defined here is kept as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bertdeblock How would I pass owner if I did that ?

export function handleSessionAuthenticated(owner, routeAfterAuthentication) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdwesten
Copy link

tdwesten commented Feb 7, 2022

Thank you for sharing this! It helpt me a lot!

@mcfiredrill
Copy link
Contributor Author

Hi, it's been awhile, but I've updated the example to use super per @bertdeblock 's suggestion.

@marcoow
Copy link
Member

marcoow commented Jul 25, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants