chore(deps): Update @sindarius/gcodeviewer #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update @sindarius/gcodeviewer to latest so it works also with gcode files generated by OrcaSlicer
meteyou
approved these changes
Jan 26, 2024
|
Thanks for your PR. I tested the G-Code again with Ocraslicer (my default slicer) and had no problems with the old version, but the update is still not wrong. |
|
Very strange, I tried latest mainsail version with orcaslicer 1.9.0 and was not working. So maybe there some incompatibilities between latest orcaslicer and the "old" dependencies. Anyway this fixes it with up to date software, like new users when installing everything from scratch. |
|
Just for reference here's something sliced with orcaslicer that was not working with latest mainsail version |
TopoDiFogna
added a commit
to TopoDiFogna/mainsail
that referenced
this pull request
Feb 17, 2024
Update @sindarius/gcodeviewer to latest after fix in upstream library. First update (d34aa64) was to include OrcaSlicer in the supported slicers list; unfortunately it was including a bug where unlisted slicer features where aborting the rendering. The new fix in the upstream library ensures that if supported slicers will add new features the render will continue to work and unsupported features will have a generic color instead of abort the render and throw an error. See Sindarius/npm_gcodeviewer@be58cce
meteyou
pushed a commit
that referenced
this pull request
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update @sindarius/gcodeviewer dependency to latest so it works also with gcode files generated by OrcaSlicer
Related Tickets & Documents
Closes #1752
Mobile & Desktop Screenshots/Recordings
No changes on frontend, just allows using the gcode viewer also with files from OrcaSlicer
[optional] Are there any post-deployment tasks we need to perform?