Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(maintenance): fix filament trigger for maintenance entries #1941

Merged

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Jul 13, 2024

Description

This PR fix the filament trigger for maintenance entries. The factor for converting mm to m was missing in the getter.

Related Tickets & Documents

fixes #1938

Mobile & Desktop Screenshots/Recordings

none

[optional] Are there any post-deployment tasks we need to perform?

none

@meteyou meteyou requested review from dw-0 and rackrick July 13, 2024 21:02
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 13, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 13, 2024
@meteyou meteyou merged commit 70a739f into mainsail-crew:develop Jul 14, 2024
12 checks passed
@meteyou meteyou deleted the fix/fix-maintenance-trigger-filament branch July 14, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance reminders popping before expected
2 participants