Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: load codemirror into a chunk for faster LCP #641

Merged
merged 3 commits into from
Feb 15, 2022
Merged

perf: load codemirror into a chunk for faster LCP #641

merged 3 commits into from
Feb 15, 2022

Conversation

pataar
Copy link
Member

@pataar pataar commented Feb 15, 2022

This loads codemirror into a seperate chuk for faster LCP.

More information: https://web.dev/lcp/

You can use the analyze label to see the difference in bundle size.

@pataar pataar changed the title perf: load codemirror into a chunk for faster FMP perf: load codemirror into a chunk for faster LCP Feb 15, 2022
@meteyou meteyou added the analyze runs build size report label Feb 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2022

Size Change: -5.74 kB (0%)

Total Size: 1.52 MB

Filename Size Change
./dist/assets/Heightmap.js 172 kB -2 B (0%)
./dist/assets/index.js 245 kB -1.68 kB (-1%)
./dist/assets/vendor.js 585 kB -117 kB (-17%) 👏
./dist/assets/Viewer.js 282 kB -2 B (0%)
./dist/index.html 637 B -3 B (0%)
./dist/assets/Codemirror.js 113 kB +113 kB (new file) 🆕
./dist/assets/Codemirror.css 20 B +20 B (new file) 🆕
ℹ️ View Unchanged
Filename Size
./dist/assets/Heightmap.css 74 B
./dist/assets/index.css 56.3 kB
./dist/assets/vendor.css 64.5 kB
./dist/assets/Viewer.css 318 B
./dist/config.json 25 B

compressed-size-action

@github-actions github-actions bot removed the analyze runs build size report label Feb 15, 2022
@meteyou meteyou added the analyze runs build size report label Feb 15, 2022
@github-actions github-actions bot removed the analyze runs build size report label Feb 15, 2022
@meteyou meteyou merged commit 6563b7c into mainsail-crew:develop Feb 15, 2022
@pataar pataar deleted the feature/chunk_load branch February 15, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants