Adds RawQuerySet to serializer #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # for example | ||
| elif isinstance(queryset, RawQuerySet) and \ | ||
| self.properties is not None : | ||
| self.serialize_queryset(queryset) |
There was a problem hiding this comment.
Why do you test self.properties ?
There was a problem hiding this comment.
It's empirical: without "properties" option, the serialization doesn't work.
|
Thank you for this contribution ! I would need a little bit more details about what you are trying to achieve. If you can do it, please also add at least a small test to run the new code! |
Add an omit_model option to serializer
Conflicts: djgeojson/serializers.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I tried to add RawQuerySet class to serializer...
Thanks!