Use RODARE api instead of hard coded URL: #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its better to use the DOI which always points to the latest version of the test data repo. This avoids updating the CI at several places each time there is a new version of the test data repo. Co-authored-by: David Pape <[email protected]>
DanielKotik
force-pushed
the
ci-test-data-download
branch
from
bf92fde
to
469c123
Compare
The top level directory in the zip file is suffixed with a commit hash that relates to the downloaded test data repository. Subsequent steps in the pipeline expect this directory have the name `test_data`. This snippet avoids manual renaming of the extracted folder with each newer version of the test data repository.
DanielKotik
force-pushed
the
ci-test-data-download
branch
from
469c123
to
849ff7d
Compare
RandomDefaultUser
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Thanks a lot for this PR @DanielKotik that looks great! I am glad we can use RODARE without having to manually update the file paths all the time.
Can be merged from my side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is better to use the DOI, which always refers to the latest version of the test data repo. This avoids updating the CI at several places each time there is a new version of the test data repo.
Closes #537