Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit: don't fix python version #569

Conversation

elcorto
Copy link
Member

@elcorto elcorto commented Aug 13, 2024

Closes #568

On a system with only Python 3.11 available, we get

$ pre-commit run -a
An unexpected error has occurred: CalledProcessError: command: ('/path/to/python/3.11.2/bin/python3.11', '-mvirtualenv', '/home/user42/.cache/pre-commit/repokdlvjmqs/py_env-python3.12', '-p', 'python3.12')
return code: 1
stdout:
    RuntimeError: failed to find interpreter for Builtin discover of python_spec='python3.12'
stderr: (none)

We could also set this to python3.11, but I guess the more portable way
is to rely on black's auto-detection.
Copy link
Member

@RandomDefaultUser RandomDefaultUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, feel free to merge!

@RandomDefaultUser RandomDefaultUser merged commit f30f085 into mala-project:develop Oct 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't fix Python version in .pre-commit-config.yaml
2 participants