Removes custom gtest package and uses ament_cmake_gtest instead #717
Conversation
agalbachicar
force-pushed
the
agalbachicar/#714_use_ament_gtest_gmock
branch
from
64bff3c
to
a51a834
Compare
|
It's ready for your review @scpeters |
test/regression/cpp/CMakeLists.txt
Outdated
| gtest | ||
| gtest_main | ||
| # gtest | ||
| # gtest_main |
There was a problem hiding this comment.
I would remove these lines rather than comment them out
There was a problem hiding this comment.
Sorry, I missed that
test/CMakeLists.txt
Outdated
|
|
||
| set_tests_properties(${BINARY_NAME} PROPERTIES TIMEOUT 240) | ||
| # set_tests_properties(${BINARY_NAME} PROPERTIES TIMEOUT 240) |
There was a problem hiding this comment.
I would remove these lines rather than comment them out
There was a problem hiding this comment.
Sorry, I missed that
test/CMakeLists.txt
Outdated
| @@ -15,7 +17,8 @@ macro(delphyne_build_tests) | |||
| string(REGEX REPLACE ".cc" "" BINARY_NAME ${GTEST_SOURCE_file}) | |||
| set(BINARY_NAME ${TEST_TYPE}_${BINARY_NAME}) | |||
|
|
|||
| add_executable(${BINARY_NAME} ${GTEST_SOURCE_file} ${sources}) | |||
| # add_executable(${BINARY_NAME} ${GTEST_SOURCE_file} ${sources}) | |||
There was a problem hiding this comment.
I would remove these lines rather than comment them out
agalbachicar
force-pushed
the
agalbachicar/#714_use_ament_gtest_gmock
branch
from
32eded2
to
73271ce
Compare
|
CI failing until #721 is merged |
…ToyotaResearchInstitute/delphyne into agalbachicar/#714_use_ament_gtest_gmock
|
@scpeters whenever you have a moment, please take a look at the output of the jobs. You will find the following log: > Invoking "sudo locale-gen en_US en_US.UTF-8"
Error: Unable to process command '::set-env name=LANG::en_US.UTF-8' successfully.
Error: The `set-env` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/and then it continues but with a failure when running: > Invoking "sudo rosdep init"
/usr/bin/sudo rosdep init
Wrote /etc/ros/rosdep/sources.list.d/20-default.list
Recommended: please run
rosdep updateIn https://github.com/ToyotaResearchInstitute/delphyne/runs/1408073772?check_suite_focus=true it can be seen that adding the suggested variable above made the step successful. |
|
This is affecting all the jobs, so I will add the fix everywhere to restore CI, then we should probably reach out to https://github.com/ros-tooling/setup-ros so they are aware of it. |
Solves #714