-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds OriginDisplay plugin to draw the inertial axes in the scene. #375
Adds OriginDisplay plugin to draw the inertial axes in the scene. #375
Conversation
the old visualizer has check boxes to toggle the axes. it's optional, but we could probably add one to the rectangle created by the plugin? |
I was trying to figure out how to do this for the agent info display, but am a little slow at qml |
I missed that. I think I know how to do it. We should call a function from QML to C++. Something like: I imagine that you are trying to build some kind of checkbox. It inherits from Button so you can implement a function in the onClicked event:
|
I'll implement the checkbox to toggle frame visibility |
Toggle visibility was implemented in 5049e95 toggle_visibility.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
} | ||
|
||
void OriginDisplay::ChangeAxesVisibility() { | ||
bool newIsVisibleValue = isVisible; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could be const.
btw why isVisible
can't be used directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might change while changing the visibility of the axes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 9fd1057
Part of #332
Implements OriginDisplay plugin with ign-gui3. Note that there are no DisplayPlugins anymore so I had to retrieve the
ScenePtr
myself. I expect something similar for agent_info_display