Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds TopicStats plugin with ignition-gui 3 #378

Merged
merged 7 commits into from
Apr 9, 2021
Merged

Adds TopicStats plugin with ignition-gui 3 #378

merged 7 commits into from
Apr 9, 2021

Conversation

francocipollone
Copy link
Collaborator

@francocipollone francocipollone commented Apr 8, 2021 •
edited
Loading

Part of #332

  • Replicates UI from TopicStats widget which uses ign-gui0.
  • Implements the same functionality.
topic_stats.mp4

agalbachicar
agalbachicar requested changes Apr 9, 2021
View reviewed changes
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @francocipollone . I left some commens, ptal.

In addition, would you confirm me if when you filter the topic stats get updated? I'm fine to mark it as a known issue and move forward if that's the case.

delphyne_gui/visualizer/icons/search.svg Show resolved Hide resolved
delphyne_gui/visualizer/CMakeLists.txt Outdated Show resolved Hide resolved
delphyne_gui/visualizer/topics_stats.hh Outdated Show resolved Hide resolved
delphyne_gui/visualizer/topics_stats.hh Outdated Show resolved Hide resolved
delphyne_gui/visualizer/topics_stats.hh Show resolved Hide resolved
delphyne_gui/visualizer/topics_stats.cc Outdated Show resolved Hide resolved
delphyne_gui/visualizer/topics_stats.cc Outdated Show resolved Hide resolved
delphyne_gui/visualizer/topics_stats.cc Outdated Show resolved Hide resolved
delphyne_gui/visualizer/topics_stats.cc Outdated Show resolved Hide resolved
delphyne_gui/visualizer/topics_stats.hh Outdated Show resolved Hide resolved
@francocipollone
Copy link
Collaborator Author

Thanks @francocipollone . I left some commens, ptal.

In addition, would you confirm me if when you filter the topic stats get updated? I'm fine to mark it as a known issue and move forward if that's the case.

Yes, the stats get updated when filtering, Wasn't it the expected behavior?

@agalbachicar
Copy link
Collaborator

Yes, the stats get updated when filtering, Wasn't it the expected behavior?

Yes! just double checking.

agalbachicar
agalbachicar approved these changes Apr 9, 2021
View reviewed changes
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit ac189dd into master Apr 9, 2021
@francocipollone francocipollone deleted the francocipollone/topic_stats branch April 9, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar agalbachicar approved these changes

@scpeters scpeters Awaiting requested review from scpeters

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francocipollone @agalbachicar