Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maliput viewer: Adds UI for layers selection. #382

Merged
merged 3 commits into from
Apr 19, 2021
Merged

Maliput viewer: Adds UI for layers selection. #382

merged 3 commits into from
Apr 19, 2021

Conversation

francocipollone
Copy link
Collaborator

Solves:
Task 3 of #377 (comment)

  • Adds UI in order to enable or disable the visualization of different layers of the meshes
  • Old visualizer's functionality is replicated.
  • When a new map is loaded the layers visualization is reset. (This behavior solves a bug in the old visualizer where checkboxes were disabled but when a new map is loaded it doesn't reflect the configuration previously set up.)
  • UI was described in a separate QML file and imported from MaliputViewerPlugin.qml main file.
ui_layers.mp4

@francocipollone francocipollone mentioned this pull request Apr 16, 2021
Closed
agalbachicar
agalbachicar requested changes Apr 19, 2021
View reviewed changes
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits.

delphyne_gui/visualizer/maliput_viewer_plugin.hh Outdated Show resolved Hide resolved
delphyne_gui/visualizer/maliput_viewer_plugin.hh Show resolved Hide resolved
delphyne_gui/visualizer/maliput_viewer_plugin.hh Outdated Show resolved Hide resolved
agalbachicar
agalbachicar approved these changes Apr 19, 2021
View reviewed changes
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit a23e396 into master Apr 19, 2021
@francocipollone francocipollone deleted the francocipollone/maliput_viewer_layer_selection branch April 19, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar agalbachicar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francocipollone @agalbachicar