Refactors the MessageWidget class #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agalbachicar
force-pushed
the
agalbachicar/#332_rename_message_widget
branch
from
25961c6
to
a322e77
Compare
scpeters
reviewed
May 15, 2021
| os << value.enumVal.value().name; | ||
| } | ||
| std::ostream& operator<<(std::ostream& os, const internal::Message::Variant& value) { | ||
| std::visit([&os](auto&& arg) { os << arg; }, value); |
scpeters
previously approved these changes
May 15, 2021
francocipollone
previously approved these changes
May 16, 2021
|
|
||
| /// @brief Holds the information of a google::protobuf::Message to be consumed | ||
| /// by a Qt widget. | ||
| /// @details Holds a variant like-struct when it is a leaf node in the message |
There was a problem hiding this comment.
nit: Techincally, it isn't holding a "variant like-struct" anymore.
| // Serializes a @p value into @p os. Provides a valid operator overload for | ||
| // internal::Message::EnumValue so the following function's lambda can be | ||
| // resolved. | ||
| std::ostream& operator<<(std::ostream& os, const internal::Message::EnumValue& value) { |
There was a problem hiding this comment.
nit: _os instead of os. _value instead of value.
| os << value.enumVal.value().name; | ||
| } | ||
| std::ostream& operator<<(std::ostream& os, const internal::Message::Variant& value) { | ||
| std::visit([&os](auto&& arg) { os << arg; }, value); |
agalbachicar
dismissed stale reviews from francocipollone and scpeters
via
c0b954d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the refactor to TopicInterfacePlugin finishes and #332 can be closed.