Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecates ign_gui0-based visualizer. #423

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

francocipollone
Copy link
Collaborator

Related to #332 (comment)

Attention
This PR removes the old visualizer and the dependency to ign-gui0

This should be merged after #405 is closed.

@agalbachicar
Copy link
Collaborator

@francocipollone would you please sync with master?

Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'll do the honors in delphyne_demos and maliput_infrastructure.

@francocipollone
Copy link
Collaborator Author

francocipollone commented Aug 4, 2021

LGTM!

I'll do the honors in delphyne_demos and maliput_infrastructure.

Thanks! btw, is it necessary for delphyne_demos? I think it is already using gui3-based visualizer. (edited: Forgot CI!!)

merging!

@francocipollone francocipollone merged commit c0cf397 into main Aug 4, 2021
@francocipollone francocipollone deleted the francocipollone/remove_ign_gui0 branch August 4, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants