Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFI and Rust API for RoadRulebook. #108

Merged
merged 6 commits into from
Jun 7, 2024
Merged

FFI and Rust API for RoadRulebook. #108

merged 6 commits into from
Jun 7, 2024

Conversation

francocipollone
Copy link
Contributor

@francocipollone francocipollone commented Jun 4, 2024 •
edited
Loading

🎉 New feature

Goes on top of #107

Related to:

Summary

  • Adds partial RoadRulebook FFI bindings
  • Adds binding to get the RoadRulebook from RoadNetwork
  • Adds DiscreteValueRule base Rust API.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

@francocipollone
FFI: Adds DiscreteValueRule bindings.
e71257d 
Signed-off-by: Franco Cipollone <[email protected]>
@francocipollone
Adds id and type_id
9ce50ba 
Signed-off-by: Franco Cipollone <[email protected]>
@francocipollone
FFI and Rust API for RoadRulebook.
99f998b 
Signed-off-by: Franco Cipollone <[email protected]>
This was referenced Jun 4, 2024
Closed
Closed
@francocipollone
Adds method to RoadNetwork.
bb53ede 
Signed-off-by: Franco Cipollone <[email protected]>
Base automatically changed from francocipollone/ffi_discrete_value_rule to main June 5, 2024 13:58
@francocipollone francocipollone marked this pull request as ready for review June 5, 2024 21:09
This was referenced Jun 5, 2024
Closed
Open
Open
agalbachicar
agalbachicar approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit 0f7ce51 into main Jun 7, 2024
3 checks passed
@francocipollone francocipollone deleted the francocipollone/road_rulebook branch June 7, 2024 00:07
@francocipollone francocipollone mentioned this pull request Jun 11, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar agalbachicar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francocipollone @agalbachicar