Adds LaneEnd. #61
Adds LaneEnd. #61
Conversation
Signed-off-by: Franco Cipollone <[email protected]>
| @@ -973,6 +973,15 @@ impl LaneSRange { | |||
| } | |||
| } | |||
|
|
|||
| /// A specific endpoint of a specific Lane. | |||
| /// This is analogous to the C++ maliput::api::LaneEnd implementation. | |||
| pub enum LaneEnd<'a> { | |||
There was a problem hiding this comment.
I like this very much.
There was a problem hiding this comment.
Is it possible to constraint the creation such that no nullptr is used?
There was a problem hiding this comment.
No nullptr will be used.
Lane is a class whose underlying value is a reference.
The methods returning lanes from the underlying cpp implementation will evaluate whether that pointer is valid or not before creating the reference.
We can meet and discuss if needed.
Btw, In a follow up PR (where I add LaneEndSet) I am changing the &Lane by Lane. You will notice why.
| let lane = road_geometry.get_lane(&lane_id); | ||
| let lane_end_start = maliput::api::LaneEnd::Start(&lane); | ||
| match lane_end_start { | ||
| maliput::api::LaneEnd::Start(lane) => assert_eq!(lane.id(), lane_id), |
There was a problem hiding this comment.
Should use another name for lane to avoid alising. Same below.
There was a problem hiding this comment.
Yeah makes sense. I am changing a bit this test in a follow-up PR. Let me address it in the next PR.
🎉 New feature
#28 #17
Summary
Checklist