Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ResourceManager and offer malidrive resources. #67

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Adds ResourceManager and offer malidrive resources. #67

merged 1 commit into from
Apr 23, 2024

Conversation

francocipollone
Copy link
Contributor

🎉 New feature

Closes #33

Summary

  • maliput: Adds maliput::ResourceManager abstraction to offer the backend resources: maliput_malidrive at the moment.
  • maliput-sdk: Offer the resources of the backends.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

@francocipollone francocipollone force-pushed the francocipollone/maliput_malidrive_resources branch from bdb3844 to 3e6cd48 Compare April 23, 2024 17:05
agalbachicar
agalbachicar approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit 7cbd267 into main Apr 23, 2024
3 checks passed
@francocipollone francocipollone deleted the francocipollone/maliput_malidrive_resources branch April 23, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar agalbachicar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide the maliput_malidrive's resources via an envar
2 participants
@francocipollone @agalbachicar