Skip to content
This repository has been archived by the owner on Sep 28, 2023. It is now read-only.

Removes unused extern C method. #7

Merged
merged 1 commit into from
Oct 15, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,15 +78,21 @@ maliput_drake/src/systems/analysis/region_of_attraction.cc
maliput_drake/src/systems/analysis/simulator_print_stats.cc
```

8. Update the CMakeLists.txt under `maliput_drake/src/` for the library targets.
8. Removes the following method from `maliput_drake/src/common/drake_assert_and_throw.cc`.
```cpp
extern "C" void drake_set_assertion_failure_to_throw_excepts()
```
To avoid having duplicated references in systems that both `maliput_drake` and `drake` are installed.

9. Update the CMakeLists.txt under `maliput_drake/src/` for the library targets.
Make sure all source files are properly listed.

9. Commit all the changes.
10. Commit all the changes.

10. Run the steps listed in the `Namespacing` section. Make a new commit per
11. Run the steps listed in the `Namespacing` section. Make a new commit per
change.

11. Test the workspace before making a PR.
12. Test the workspace before making a PR.

### Namespacing

Expand Down
16 changes: 0 additions & 16 deletions maliput_drake/src/common/drake_assert_and_throw.cc
Original file line number Diff line number Diff line change
Expand Up @@ -69,19 +69,3 @@ void AssertionFailed(const char* condition, const char* func, const char* file,

} // namespace internal
} // namespace maliput::drake

// Configures the DRAKE_ASSERT and DRAKE_DEMAND assertion failure handling
// behavior.
//
// By default, assertion failures will result in an ::abort(). If this method
// has ever been called, failures will result in a thrown exception instead.
//
// Assertion configuration has process-wide scope. Changes here will affect
// all assertions within the current process.
//
// This method is intended ONLY for use by pydrake bindings, and thus is not
// declared in any header file, to discourage anyone from using it.
extern "C" void drake_set_assertion_failure_to_throw_exception() {
maliput::drake::internal::AssertionConfig::singleton().
assertion_failures_are_exceptions = true;
}